Fix/ub 1675 support fc and iscsi #254
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @olgashtivelman and @shay-berman)
utils/utils.go, line 41 at r1 (raw file):
bool, err := strconv.ParseBool(os.Getenv("SCBE_SKIP_RESCAN_ISCSI")) if err != nil { config.ScbeRemoteConfig.SkipRescanISCSI = false
-
please rebase the PR from dev, because i pumb in the scale helm support.
-
you should also remove the skip rescan not only from the golang code, you should remove it from all the helm chart and old installer (values or yml files). please do grep for this rescan thing and make sure you removed it from all the places.
-
please make sure Dima know about this fix, and has a dedicated ticket to remove any documentation about this param, but also have documentation that explain the new behavius in the UG.
There was a problem hiding this comment.
Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @shay-berman)
utils/utils.go, line 41 at r1 (raw file):
Previously, shay-berman wrote…
please rebase the PR from dev, because i pumb in the scale helm support.
you should also remove the skip rescan not only from the golang code, you should remove it from all the helm chart and old installer (values or yml files). please do grep for this rescan thing and make sure you removed it from all the places.
please make sure Dima know about this fix, and has a dedicated ticket to remove any documentation about this param, but also have documentation that explain the new behavius in the UG.
regarding 1+2 see changes.
regarding documentation i will consult Dima.
There was a problem hiding this comment.
Merge to dev this Pr (and IBM/ubiquity#267) into dev after you have green light from Staging CI.
Reviewable status: 0 of 11 files reviewed, all discussions resolved
in this PR the idea is to allow the user to use ISCSI + FC on the same kubernetes cluster.
before this PR the user had to define a config parameter : skipRescanIscsI to define if they want to use ISCSI or not in ubiquity.
this PR reomves this config and works under the assumption that if a user defined and installed iscsiadm on the node then this node should be connected to the storage system with ISCSI. also the existance of the iscsiadm command or a login to the storage will not fail the rescan and the mount\umount process!
Note: This PR also related to IBM/ubiquity#267
This change is