DS8K support : change ibm-ubiquity-db to configurable

[hfeish]

get ibm ubiquity db name from ubiquity Pod env setting.

k8s side of thing -> IBM/ubiquity-k8s#167

Signed-off-by: feihuang feihuang@feihuangs-mbp.cn.ibm.com

---

This change is 

[coveralls]

Coverage decreased (-0.07%) to 54.731% when pulling fe2a3be on fix/UB-945_Ubiquity_For_DS8k_P3 into c94b05f on dev.

[shay-berman]

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

---

database/volume.go, line 26 at r1 (raw file):

var VolumeNameSuffix = os.Getenv(keyPsqlDbPVName)
//const VolumeNameSuffix = "ibm-ubiquity-db"

You should apply here a critical fix:
We need to set a default value in case KeyPsqlDBPVname is not defined, in order to support customer that didn't upgrade the yml file.
So please if env is empty, then set it to VolumeNameSuffix. So uncomment the const and use it as default

In addition make sure we don't have other ibm-ubiquity-db in the code that we forgot to change.

thanks

---

Comments from Reviewable

[shay-berman]

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.

---

database/volume.go, line 26 at r1 (raw file):

Previously, shay-berman wrote…

You should apply here a critical fix:
We need to set a default value in case KeyPsqlDBPVname is not defined, in order to support customer that didn't upgrade the yml file.
So please if env is empty, then set it to VolumeNameSuffix. So uncomment the const and use it as default

In addition make sure we don't have other ibm-ubiquity-db in the code that we forgot to change.

thanks

ok good I saw your fix for that.
now its ok. thanks

---

database/volume.go, line 36 at r2 (raw file):

}

func getDBVolumeName(dbPVNameENVKey string) string {

If posible move this function to utils, and call it getEnv(envName, defaultValue) and make it generic.

---

Comments from Reviewable

[hfeish]

@shay-berman move func to get dbname from ENV to IBM/ubiquity/utils/utils

[hfeish]

Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

database/volume.go, line 36 at r2 (raw file):

Previously, shay-berman wrote…

If posible move this function to utils, and call it getEnv(envName, defaultValue) and make it generic.

move this function to Ubiquity/Utils/utils, and make it generic

---

Comments from Reviewable

[shay-berman]

---

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

Comments from Reviewable