-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sg_inq parsing the WWN during the device discovery. #195
Conversation
…r to the wording.
Review status: 0 of 2 files reviewed at latest revision, all discussions resolved. remote/mounter/block_device_utils/block_device_utils_test.go, line 145 at r1 (raw file):
Tzur remote/mounter/block_device_utils/mpath.go, line 188 at r1 (raw file):
please add a comment in the code here - that zlinux sg_inq return "Vendor Specific Extension Identifier" while x86 return "Vendor Specific Identifier Extension" Comments from Reviewable |
remote/mounter/block_device_utils/mpath.go, line 188 at r1 (raw file):
The following would be more accurate "Vendor Specific (Identifier Extension|Extension Identifier):" Comments from Reviewable |
Review status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions. remote/mounter/block_device_utils/block_device_utils_test.go, line 145 at r1 (raw file): Previously, shay-berman wrote…
I think it should be added in both. But I can move it to GetWwnByScsiInq if you say it's better there. remote/mounter/block_device_utils/mpath.go, line 188 at r1 (raw file): Previously, shay-berman wrote…
done remote/mounter/block_device_utils/mpath.go, line 188 at r1 (raw file): Previously, alonm wrote…
Thought of that a bit later. you are correct of course, it'll prevent us from receiving false lines. Comments from Reviewable |
Reviewed 2 of 2 files at r1. Comments from Reviewable |
NOTE : Reviewed 2 of 2 files at r2. Comments from Reviewable |
Updated the title of the PR and the description according to the finding today. We should merge it tomorrow to dev branch after sanity test. |
Internal ticket UB-1030.
Validate the WWN of the discovered device done by sg_inq. But we have a bug there that the parsing sg_inq output is not working well for XIV because different outline of the sg_inq output.
(was found while testing Ubiquity on zLinux)
This change is