UB-1408: fix idempotent issue#6 - dont raise error on detach in ubiquity server

[olgashtivelman]

In the ubiquity server if the volume is already detached we will not fail the flow but succeed.

---

This change is 

[coveralls]

Coverage decreased (-0.07%) to 57.268% when pulling 6070552 on fix/UB-1408_dont_send_detach_if_volume_already_detached into 7611848 on dev.

[shay-berman]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @olgashtivelman and @shay-berman)

---

local/scbe/scbe_test.go, line 501 at r1 (raw file):

			Expect(err).To(MatchError(fakeErr))
		})
		It("should fail to detach the volume if vol not exist in DB", func() {

please change the test description, because its should not fail.
make sure u cover it ok

[shay-berman]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @olgashtivelman)

---

local/scbe/scbe_test.go, line 501 at r1 (raw file):

Previously, shay-berman wrote…

please change the test description, because its should not fail.
make sure u cover it ok

After fixing that then its

[olgashtivelman]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @shay-berman)

---

local/scbe/scbe_test.go, line 501 at r1 (raw file):

Previously, shay-berman wrote…

After fixing that then its
:lgtm:

Done.