Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ub-1436 umount when pv does not exist #241

Merged
merged 2 commits into from
Aug 27, 2018

Conversation

olgashtivelman
Copy link
Collaborator

@olgashtivelman olgashtivelman commented Aug 27, 2018

the getBackend function in the storage_api_handler was returning the wrong error message and the controller was expecting the right one, so i fixed it to return the correct error.


This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 51.98% when pulling 6c68795 on fix/UB-1436_umount_when_pv_does_not_exist into ce75e33 on dev.

Copy link
Contributor

@shay-berman shay-berman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@olgashtivelman olgashtivelman merged commit 740b73b into dev Aug 27, 2018
@olgashtivelman olgashtivelman deleted the fix/UB-1436_umount_when_pv_does_not_exist branch August 27, 2018 09:27
@shay-berman shay-berman added the idempotency Improve Flex API idempotency aspects label Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idempotency Improve Flex API idempotency aspects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants