Modify volume size unit from gb to gib #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shay-berman
approved these changes
Dec 4, 2018
There was a problem hiding this comment.
But before your merge it to dev please do:
- run staging on this change
- if staging green then don't forget to update the glide yml on the ubiqutiy-k8s side of thing.
- then marge both PRs to dev.
NOTE - you change in this PR is global for all storage system, please make sure it works well on A9000 as well!
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
|
closing this PR because @olgashtivelman already merge back the release branch into dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the pvc unit is gib in yaml file, but ubiquity sent to scb with unit gb.
That caused the volume size is not correct.
As confirmed with SCB developer, SCB support both unit gib and gb.
I just modify the unit from gb to gib in this patch.
This change is