Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ubiquity slack notifications #301

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Remove ubiquity slack notifications #301

merged 1 commit into from
Mar 28, 2019

Conversation

shay-berman
Copy link
Contributor

@shay-berman shay-berman commented Mar 27, 2019 •
edited by midoblgsm

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.175% when pulling 833f728 on remove_slack_token into 9820a84 on dev.

@shay-berman shay-berman requested a review from ranhrl March 27, 2019 14:45
@shay-berman shay-berman added this to the Helm chart support milestone Mar 27, 2019
shay-berman
shay-berman commented Mar 28, 2019
View reviewed changes
Copy link
Contributor Author

@shay-berman shay-berman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ranhrl)

@shay-berman shay-berman merged commit 8994dcf into dev Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranhrl ranhrl Awaiting requested review from ranhrl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Helm chart support
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shay-berman @coveralls