Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UB-1977 exclude the warning messages in multipath output #303

Merged
merged 2 commits into from
Apr 7, 2019

Conversation

27149chen
Copy link
Contributor

@27149chen 27149chen commented Apr 5, 2019

The multipath output might print some warning messages if some devices are faulty, it has impact on the function isDeviceFaulty. I have no time to improve this fucntion, I will exclude these messages in 2.1 release.

Here is an example output:

Apr 04 16:13:40 | sde: couldn't get target port group
Apr 04 16:13:40 | sdd: couldn't get target port group
mpathj (3600507680c8701159800000000001af4) dm-17 IBM     ,2145            
size=1.0G features='1 queue_if_no_path' hwhandler='0' wp=rw
|-+- policy='service-time 0' prio=0 status=active
| `- 39:0:0:1 sde 8:64 failed faulty running
`-+- policy='service-time 0' prio=0 status=enabled
  `- 40:0:0:1 sdd 8:48 failed faulty running
mpathi (3600507680c8701159800000000001af3) dm-14 IBM     ,2145            
size=20G features='1 queue_if_no_path' hwhandler='0' wp=rw
|-+- policy='service-time 0' prio=50 status=active
| `- 40:0:0:0 sdb 8:16 active ready running
`-+- policy='service-time 0' prio=10 status=enabled
  `- 39:0:0:0 sdc 8:32 active ready running

This change is Reviewable

Signed-off-by: 27149chen <7991675+27149chen@users.noreply.github.com>
@27149chen 27149chen added this to the Helm chart support milestone Apr 5, 2019
@27149chen 27149chen self-assigned this Apr 5, 2019
Signed-off-by: 27149chen <7991675+27149chen@users.noreply.github.com>
@coveralls
Copy link

coveralls commented Apr 5, 2019

Coverage Status

Coverage increased (+0.2%) to 59.359% when pulling 527910e on feature/UB-1977_warning_messages_in_multipath_output into 3f22f0e on dev.

Copy link
Contributor

@shay-berman shay-berman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must say that I don't like the specific error message catch here, because the error message can change and maybe other errors could happened as well. So i think that we should have more flexible scan that search for specific things and less sensitive to noise in the output. (Maybe open a ticket in jira to remember that this should be improved).

but anyway, since its the last minute of the release, and if its blocking then go a head and merge (make sure it pass staging).

:lgtm:

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @shay-berman)

Copy link
Contributor Author

@27149chen 27149chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you, in fact I find a more efficient way to parse the multipath output: to print the multipath result in json. Will do it later.

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @27149chen)

@27149chen 27149chen merged commit b758e1f into dev Apr 7, 2019
@27149chen 27149chen deleted the feature/UB-1977_warning_messages_in_multipath_output branch April 7, 2019 14:19
@shay-berman
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants