Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce arabic to normalized sacrebleu #638

Merged
merged 3 commits into from
Mar 18, 2024
Merged

introduce arabic to normalized sacrebleu #638

merged 3 commits into from
Mar 18, 2024

Conversation

pklpriv
Copy link
Member

@pklpriv pklpriv commented Mar 7, 2024

No description provided.

@pklpriv pklpriv marked this pull request as draft March 7, 2024 18:57
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.50%. Comparing base (8fa7674) to head (9ae2bb3).

❗ Current head 9ae2bb3 differs from pull request most recent head b1f27d2. Consider uploading reports for the commit b1f27d2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #638      +/-   ##
==========================================
+ Coverage   89.48%   89.50%   +0.01%     
==========================================
  Files          90       90              
  Lines        8744     8566     -178     
==========================================
- Hits         7825     7667     -158     
+ Misses        919      899      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pklpriv pklpriv marked this pull request as ready for review March 12, 2024 16:20
@piotrhelm
Copy link

@pklpriv Can you add support for Korean also?

@LukaszCmielowski
Copy link
Member

@yoavkatz could you please take a look and merge ?. Thx.

@yoavkatz yoavkatz merged commit 5f2912f into main Mar 18, 2024
4 of 5 checks passed
@elronbandel elronbandel deleted the 1.6.7 branch April 8, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants