Add LogProbInferenceEngines API and implement for OpenAI #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lilacheden
commented
Jun 16, 2024
lilacheden
commented
- add logprobs option
- add data_classification_policy
- fix return type to a list of strings as in other inference engines
…ix returned data Signed-off-by: lilacheden <lilach.edel@gmail.com>
Signed-off-by: lilacheden <lilach.edel@gmail.com>
arielge
approved these changes
Jun 16, 2024
OfirArviv
previously requested changes
Jun 16, 2024
to inference engine Signed-off-by: Yoav Katz <katz@il.ibm.com>
Signed-off-by: lilacheden <lilach.edel@gmail.com>
Signed-off-by: lilacheden <lilach.edel@gmail.com>
OfirArviv
reviewed
Jun 17, 2024
OfirArviv
reviewed
Jun 17, 2024
yoavkatz
changed the title
to avoid needing to define method of engines that don't support it. Signed-off-by: Yoav Katz <katz@il.ibm.com>
yoavkatz
changed the title
Signed-off-by: Yoav Katz <katz@il.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.