-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Console error when loading PlayerAPI in React #10
Comments
Hi @stephenhamm, |
👋 Hi again, I put together a little project with create-react-app based on your use-case here: Apart from seeing that error message does the api work? I couldn't consistently reproduce that error message, but when I saw it, the api still worked for me after the sso process finished. I tested it in chrome and firefox, both on localhost:3000 and on gh-pages. We are executing some code when the videos' iframe loads and in case of SSO it can happen a few times. I suspect that the error happens when the Here you can check the example in action: |
Yes @jungdaniel , the API works even when that message shows up. And you are also right when you say that the message shows up sometimes, and sometimes doesn't. |
Yes, I see your point. I guess we can wrap the |
Thanks a lot @jungdaniel for looking into this and possibly closing in on a resolution. |
Hi @jungdaniel , any luck with this? |
Hi @jungdaniel , any update? |
Hi @pooshonbanerjee, |
Thanks Jung.
Regards
Pooshon Banerjee
…On Wed, 13 Oct, 2021, 3:17 pm Jung Dániel, ***@***.***> wrote:
Hi @pooshonbanerjee <https://github.com/pooshonbanerjee>,
It seems that with a try catch block we won't be able to suppress this
kind of message. I am looking for another solution right now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJTJE6CLLH4XV57OJPAK5KDUGVISJANCNFSM5ERISKJA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
@pooshonbanerjee @stephenhamm, Unfortunatelly we couldn't find a solution for this issue. I couldn't catch these errors neither with |
Thanks @jungdaniel for the reply. Would this timeout be built-in on your end or is it something we have to implement? |
Would be built in this lib. |
Thanks @jungdaniel |
Hi @jungdaniel , any idea when this new update will be released? |
Hi @jungdaniel , any update on this? |
My team is having an issue with the Player API loading in React 16. This console error is showing whenever the player is loaded.
Recently someone from my team created an issue here (#6) and it was resolved. This ticket saw the introduction of the 'api-target-origin' parameter for the player's iframe. While my colleague was able to get this to work in Angular, the issue is still persisting in React.
The Player API is imported into our component
![Screen Shot 2021-09-22 at 9 48 25 AM](https://user-images.githubusercontent.com/63255907/134346399-50735746-8642-45dc-be8d-eaa370371072.png)
The api-target-origin is included in the source, as well as the rootUrl (which in our case is http://localhost:3000).
![Screen Shot 2021-09-22 at 9 48 55 AM](https://user-images.githubusercontent.com/63255907/134346499-ae6e7efe-a539-42ac-812d-de7beb843786.png)
The iframe's source is set.
![Screen Shot 2021-09-22 at 9 49 53 AM](https://user-images.githubusercontent.com/63255907/134346584-b2be1810-94d8-43f7-9a5e-388a6d99f8a6.png)
The request being sent to Watson is as follows, which includes the api-target-origin.
https://video.ibm.com/embed/recorded/130908580?html5ui&api-target-origin=http://localhost:3000&showtitle=true&allowfullscreen=false&volume=50
In my colleagues notes in the previous ticket, the 'html5ui=' parameter comes after the 'api-target-origin' param, so even trying this as a hardcoded value still produces the error.
![Screen Shot 2021-09-22 at 9 53 18 AM](https://user-images.githubusercontent.com/63255907/134347098-15e3bd95-4fe0-45da-825b-4dfe87ec0c38.png)
He mentions that the error happens when the SSO dialogue window is present, but i'm seeing the error in the console even when already signed in.
I also noticed that there are two requests sent, one coming back with a 301 and another with 200.
The full file contents are as follows.
Any further help with this would be very much appreciated. Thanks!
The text was updated successfully, but these errors were encountered: