Length penalty draft #10
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
prashantgupta24
force-pushed
the
release
branch
from
4ea041f
to
87300e2
Compare
tjohnson31415
force-pushed
the
release
branch
2 times, most recently
from
37c6791
to
fc9fe28
Compare
joerunde
force-pushed
the
release
branch
2 times, most recently
from
7a0007c
to
64b18a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first go at implementing the length penalty in vLLM, just to get some feedback. But from our meeting earlier Nick hinted that there might be another way to implement this in our TGIS wrapper, without going deep in the vLLM implementation, so I'll try that approach too.
The relevant change in this draft are in sampler.py
I'm basing this PR on Joe's request-validation branch because it builds on some of the new features there, but I'm also pulling in some recent changes from the release branch here.