Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COBOL - Error while processing boolean compilation variables #321

Closed
1 of 5 tasks
FALLAI-Denis opened this issue Feb 21, 2023 · 3 comments
Closed
1 of 5 tasks

COBOL - Error while processing boolean compilation variables #321

FALLAI-Denis opened this issue Feb 21, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@FALLAI-Denis
Copy link

FALLAI-Denis commented Feb 21, 2023

Development environment used

  • Z Open Editor version: 3.0.1
  • Editor Platform
    • Visual Studio Code
    • Red Hat CodeReady Workspaces
    • Eclipse Che
    • Standalone Theia
  • Editor Platform Version: 1.75.1
  • Operating System: Windows 10 22H2
  • Java Version: V11
  • Related to RSE API?
    • RSE API Plugin version:
    • Zowe CLI version:
    • Node.js version:
  • Logs attached: no

Problem Description

The COBOL Language Server does not correctly handle condition expressions on compilation variables in boolean format compared with the constant b'0' or b'1', which subsequently triggers parse errors at the global level and emitting false syntax errors.

image

Problems also on parsing the >>evaluate directive:

image

image

@phaumer phaumer added the bug Something isn't working label Feb 21, 2023
@FALLAI-Denis
Copy link
Author

Hi,

I haven't tested it but I think that if the management of conditional compilation does not work at the Language Server level, and this leads to poor or false detection of the COPYBOOKs actually used by the program during compilation, this must have a impact on the IBM User Build function (call to DBB-zAppbuild): copybooks will be missing (transfer from local to remote system) when compiling User Build.

In general, the poor management of conditional compilation by the COBOL Language Server causes us many problems and makes most of the features specific to Z Open Editor unusable (any syntax error disables many features in ZOE).

Perhaps you should consider no longer managing conditional compilations and considering that all the source lines are part of the program (management by excess, but at least the "necessary" is managed, in the absence of the "sufficient"), or provide an option to allow disabling conditional compilation support in the COBOL Language Server.

In any case, we want substantive and rapid action on the problems related to the management of conditional compilation in the COBOL Language Server because we have now switched to intensive use mode of Z Open Editor and these problems are becoming critical for us.

@FALLAI-Denis
Copy link
Author

FALLAI-Denis commented Feb 22, 2023

See #154, #203, #199, #113, #96, #88, #83

@phaumer
Copy link
Member

phaumer commented Mar 10, 2023

Fixed in Z Open Editor 3.1.0

@phaumer phaumer closed this as completed Mar 10, 2023
@kristinochka kristinochka removed the bug Something isn't working label Apr 10, 2023
@phaumer phaumer added the bug Something isn't working label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants