Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cobol Language Server - "Full red program" after LS analysis #154

Closed
1 of 5 tasks
FALLAI-Denis opened this issue Sep 2, 2021 · 4 comments
Closed
1 of 5 tasks

Cobol Language Server - "Full red program" after LS analysis #154

FALLAI-Denis opened this issue Sep 2, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@FALLAI-Denis
Copy link

FALLAI-Denis commented Sep 2, 2021

Development environment used

  • Z Open Editor version: 1.2.6
  • Editor Platform
    • Visual Studio Code
    • Red Hat CodeReady Workspaces
    • Eclipse Che
    • Standalone Theia
  • Editor Platform Version: 1.59.1
  • Operating System: Windows 10 1909 Pro 64 bits
  • Java Version: java version "1.8.0_102" / Java(TM) SE Runtime Environment (build 1.8.0_102-b14) / Java HotSpot(TM) 64-Bit Server VM (build 25.102-b14, mixed mode)
  • Related to RSE API?
    • RSE API Plugin version:
    • Zowe CLI version:
    • Node.js version:
  • Logs attached: yes

zopeneditor-20210902-155921.log

Problem Description / Observed behavior

A COBOL program uses:

  • COPYBOOK (all are local)
  • conditional compilation (with variables declared in the program and tested in the COPYBOOKs)
  • COBOL Sections

When the program is loaded in the editor, everything is OK.

After a certain analysis time, and a priori after processing by the COBOL Language Server, most of the COBOL code turns red, with incomprehensible error messages.

image

The COBOL editor becomes unusable (unreadable) because all code is underlined in error mode.

However, the COBOL code is correct and compiles without errors.

If we stop the COBOL Language Server, the errors disappear and the editor becomes usable again, but all the advanced functions for working on the COBOL code are no longer available.

The memory size allowed for the COBOL Language Server has been increased to 2048, without improvement.

Expected behavior

It would be necessary to be able to trace / debug the COBOL Language Server to be able to identify when the problem appears.

usecase.zip

In the attached zip file, you will find the use case, with the initial COBOL source and its COPYBOOKs, the compilation listing, and a COBOL source processed by MDECK(NOCOMPILE) option to expand COPYBOOKs and resolve conditional compilation.

The COBOL MDECK source does not produce the same parsing errors as the original COBOL source, but unreachable code is incorrectly detected (as proven by compilation in OPTIMIZE(1) mode), same as #127 ?.

@gplambert gplambert added the bug Something isn't working label Sep 3, 2021
@FALLAI-Denis
Copy link
Author

Hi,

Is there any chance that a solution or at least an improvement to this problem will be available by the end of this year?

We must switch to a pilot phase (proof of solution) at the start of 2022. As it stands, this is not possible and our project risks being called into question.

Although an improvement does not correct all the problems, the editor should be usable by limiting the reporting of false errors without having to deactivate the Language Server.

Thanks.

@FALLAI-Denis
Copy link
Author

Hi,

The transition to ZOE 3.0.x has worsened the situation, and again our programs are almost totally in error, to the point of having to stop the COBOL Language Server to be able to work on the source codes.

The problem seems to relate to the handling of copybooks with replacing and the use of conditional compilation outside or inside those copybooks.
On the same program with resolution of copybooks and conditional compilation (source created with MDECK(NOCOMPILE) compilation), there are no longer any errors detected by ZOE.

@phaumer
Copy link
Member

phaumer commented Nov 28, 2023

@FALLAI-Denis we made some more improvements in v3.3.2 for this issue. Can you verify?

@FALLAI-Denis
Copy link
Author

Hi,

Thanks for these improvements.

The problem has disappeared.
But other issues that were hidden have appeared: I'm opening another request for these new issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants