Update mentions extractors #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
…can use entities with descriptions. Added TARS and SMXM as mentions extractors Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
… force garbage collector due to memory problems Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
marmg
force-pushed
the
feat/update-mentions-extractor
branch
from
7dc4bdd
to
59fea41
Compare
GabrielePicco
pushed a commit
that referenced
this pull request
Oct 28, 2022
* Added POS Mentions extractor * Added v2 pos mentions extractor * Added ZShot Param class to help user to register new components * Added ZShot PipelineConfig * Added zshot serialization * Updated zshot seriailzation * Fixed test_zshot * blank * ♻️ Refactor code * ♻️ Use tempdir for temporary directory * ♻️ Rename disable_default_ner field * Updated serialization test * ⏪ Remove external code Co-authored-by: Gabriele Picco <Gabriele.Picco@ibm.com>
GabrielePicco
pushed a commit
that referenced
this pull request
Oct 28, 2022
* Added POS Mentions extractor * Added v2 pos mentions extractor * Added ZShot Param class to help user to register new components * Added ZShot PipelineConfig * Added zshot serialization * Updated zshot seriailzation * Fixed test_zshot * blank * ♻️ Refactor code * ♻️ Use tempdir for temporary directory * ♻️ Rename disable_default_ner field * Updated serialization test * ⏪ Remove external code Co-authored-by: Gabriele Picco <Gabriele.Picco@ibm.com>
GabrielePicco
pushed a commit
that referenced
this pull request
Oct 28, 2022
* 🎨 Refactored mentions extractor to work with zshot spans. * 🐛 Fixed bug in linker_regen when there are no mentions to link * ✨ Added mentions to PipelineConfig and ZShot, now mentions extractor can use entities with descriptions. Added TARS and SMXM as mentions extractors * ✅ Added tests for SMXM and TARS mentions extractors. Updated tests to force garbage collector due to memory problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As discussed in #18, some Mentions extractor may use entities with descriptions that may be different from the ones used by the lnker.
Solution
Add a new field, mentions, to allow the usage of different entities in the mentions extractors.
Also, added TARS and SMXM models as mentions extractors.
Other changes (e.g. bug fixes, small refactors)
MentionsExtractorto usezshot.utils.data_models.span.Spaninstead ofspacy.tokens.spanas discussed in Refactor mentions extractor #19Closes #18, #19