Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed bug in run_evaluation #32

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Conversation

marmg
Copy link
Collaborator

@marmg marmg commented Nov 15, 2022

Status Type ⚠️ Core Change Issue
Ready Bug No

Problem

What problem are you trying to solve?
Allow evaluation with multiple datasets. Fix bug in run_evaluation

Solution

How did you solve the problem?

  • Modify run_evaluation script to allow usage of multiple datasets.
  • Modify zshot_evaluate to load the datasets

Other changes (e.g. bug fixes, small refactors)

  • Added Regen Linker to run_evaluation script

Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Copy link
Contributor

@GabrielePicco GabrielePicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GabrielePicco GabrielePicco merged commit 3ae7066 into main Nov 15, 2022
@GabrielePicco GabrielePicco deleted the fix/type-not-subscriptable branch November 15, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants