🐛 Fix bug in evaluation with both mentions extractors and linkers #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
marmg
force-pushed
the
fix/result-overwritten
branch
from
8986c21
to
6dbcbb1
Compare
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Codecov ReportBase: 92.14% // Head: 92.14% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=======================================
Coverage 92.14% 92.14%
=======================================
Files 67 67
Lines 2726 2726
=======================================
Hits 2512 2512
Misses 214 214 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using both mentions extractor and linkers in the evaluation the result is overwritten
Solution
Update the result without overwritten it
Closes #33