Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility of changing pretrained smxm model #37

Merged
merged 3 commits into from
Nov 18, 2022

Conversation

marmg
Copy link
Collaborator

@marmg marmg commented Nov 18, 2022

Status Type ⚠️ Core Change Issue
Ready Feature Yes

Problem

SMXM may have different pre-trained models. Currently only one can be used.

Solution

Add a parameter in the __init__ to allow usage of different models.

Other changes (e.g. bug fixes, small refactors)

  • Change descriptions of MedMentions entities.

Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 92.14% // Head: 92.18% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (1be75ab) compared to base (eebbbb1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   92.14%   92.18%   +0.03%     
==========================================
  Files          67       67              
  Lines        2726     2765      +39     
==========================================
+ Hits         2512     2549      +37     
- Misses        214      216       +2     
Impacted Files Coverage Δ
zshot/linker/linker_smxm.py 96.77% <100.00%> (+0.10%) ⬆️
...shot/mentions_extractor/mentions_extractor_smxm.py 100.00% <100.00%> (ø)
zshot/utils/displacy/displacy.py 73.07% <0.00%> (-2.44%) ⬇️
zshot/tests/evaluation/test_datasets.py 100.00% <0.00%> (ø)
...ot/evaluation/dataset/med_mentions/med_mentions.py 100.00% <0.00%> (ø)
zshot/tests/utils/test_displacy.py 93.93% <0.00%> (+0.83%) ⬆️
zshot/evaluation/dataset/dataset.py 93.75% <0.00%> (+1.44%) ⬆️
zshot/evaluation/dataset/ontonotes/onto_notes.py 70.17% <0.00%> (+5.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

zshot/linker/linker_smxm.py Outdated Show resolved Hide resolved
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
@GabrielePicco GabrielePicco merged commit 02a7946 into main Nov 18, 2022
@GabrielePicco GabrielePicco deleted the feat/medmentions-smxm branch November 18, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants