Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Change name of MedMentions dataset #38

Merged
merged 7 commits into from
Nov 29, 2022
Merged

Conversation

marmg
Copy link
Collaborator

@marmg marmg commented Nov 29, 2022

Status Type ⚠️ Core Change Issue
Ready Refactor No Link

Problem

MedMentions-ZS dataset in Huggingface Hub has a wrong preprocess.

Solution

Change of MedMentions-ZS dataset to get the new version with the right preprocess.

Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 92.18% // Head: 92.18% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a374655) compared to base (2a84de0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files          67       67           
  Lines        2763     2765    +2     
=======================================
+ Hits         2547     2549    +2     
  Misses        216      216           
Impacted Files Coverage Δ
...ot/evaluation/dataset/med_mentions/med_mentions.py 100.00% <100.00%> (ø)
zshot/linker/linker_smxm.py 96.77% <100.00%> (+0.10%) ⬆️
...shot/mentions_extractor/mentions_extractor_smxm.py 100.00% <100.00%> (ø)
zshot/tests/evaluation/test_datasets.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@GabrielePicco GabrielePicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marmg marmg merged commit 0a847e6 into main Nov 29, 2022
@marmg marmg deleted the feat/medmentions-smxm branch November 29, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants