Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added scores to regen #55

Merged
merged 3 commits into from
Jun 29, 2023
Merged

✨ Added scores to regen #55

merged 3 commits into from
Jun 29, 2023

Conversation

marmg
Copy link
Collaborator

@marmg marmg commented Jun 29, 2023

Status Type ⚠️ Core Change Issue
Ready Feature No #54

Problem

Add Softmax scores to Regen spans

Closes #54

Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (e5e0c7f) 92.81% compared to head (6357a63) 92.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   92.81%   92.83%   +0.02%     
==========================================
  Files          73       73              
  Lines        3034     3043       +9     
==========================================
+ Hits         2816     2825       +9     
  Misses        218      218              
Impacted Files Coverage Δ
zshot/linker/linker_regen/linker_regen.py 98.50% <100.00%> (+0.20%) ⬆️
zshot/linker/linker_smxm.py 96.66% <100.00%> (+0.11%) ⬆️
zshot/tests/linker/test_tars_linker.py 95.00% <100.00%> (ø)
...mentions_extractor/test_tars_mentions_extractor.py 93.54% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marmg marmg merged commit 0307ee4 into main Jun 29, 2023
6 checks passed
@marmg marmg deleted the fix/regen-softmax branch June 29, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Add Softmax to LinkerRegen scores
1 participant