Fixes for #32, #37, #39 and #41 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide code comments on the authentication classes and how they use/integrate with OAuth, e.g. what's the role of each class etc. Looks like this would be good to add to the other operators in this toolkit but other coders should be able to easily understand code, not have to figure everything out from scratch. |
|
i'm not sure why i'm not getting any notifications about some comments. |
|
this should be fixed now. can someone please re-evaluate the pull request |
|
will do |
ddebrunner
added a commit
that referenced
this pull request
Apr 26, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.