Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a standard message type. #15

Closed
ddebrunner opened this issue Aug 25, 2017 · 5 comments
Closed

Add a standard message type. #15

ddebrunner opened this issue Aug 25, 2017 · 5 comments

Comments

@ddebrunner
Copy link
Member

The operators default to looking for a schema with key and message, it would be good to have such a type ready to use in this and the kafka toolkit.

@cancilla
Copy link
Collaborator

cancilla commented Sep 5, 2017

What would the attribute types be for key and message since the operators support multiple types for keys and messages.

@ddebrunner
Copy link
Member Author

How many combinations are there, four ? (rstring,blob) x (key,message) ?

@cancilla
Copy link
Collaborator

cancilla commented Sep 5, 2017

Both the key and message support any combination of the following types:

  • rstring,
  • int32/int64
  • uint32/uint64
  • float64
  • blob

@ghost
Copy link

ghost commented Dec 3, 2018

What would be the most used combinations? I guess these both:
type StringMessage = tuple <rstring message, rstring key>;
and
type BlobMessage = tuple <blob message, rstring key>;

In my opinion, all other SPL types are rarely used in Kafka messages for key or value.

ghost pushed a commit that referenced this issue Dec 4, 2018
@ghost
Copy link

ghost commented Dec 4, 2018

MessageType.StringMessage = rstring message, rstring key;
MessageType.BlobMessage = blob message, rstring key;
MessageType.ConsumerMessageMetadata = rstring topic, int32 partition, int64 offset, int64 messageTimestamp;
MessageType.TopicPartition = rstring topic, int32 partition;

implemented in 1.7.0 release

@ghost ghost closed this as completed Dec 4, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants