Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_view_obj() removed, resolves #942 #2394

Merged
merged 1 commit into from
Mar 20, 2020
Merged

get_view_obj() removed, resolves #942 #2394

merged 1 commit into from
Mar 20, 2020

Conversation

markheger
Copy link
Member

No description provided.

@markheger markheger requested a review from a user March 20, 2020 11:24
ghost
ghost reviewed Mar 20, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_view_object is unused in this Python package - safe to delete. The assumption is, that the function is not part of the public API as it has no documentation?

@markheger
Copy link
Member Author

get_view_object is unused in this Python package - safe to delete. The assumption is, that the function is not part of the public API as it has no documentation?

No sample or test case found, that uses this function

rest tests passed

ghost
ghost approved these changes Mar 20, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As get_view_obj has no Py doc, it will most likely not be used by anybody.

@markheger markheger merged commit e005ca4 into IBMStreams:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@markheger