Fix topology name and namespace when one of them is an SPL reserved word #2475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2474
The resolution is, that tokens in the namespace, which are SPL keywords, are replaced by
__spl_
+ some hash. Name and namespace are manipulated anyway, for example, non-word characters are removed, and empty tokens should be dropped. "Should be", because it did not work.The Java code generation has a test for vaild identifiers regular expression, but does not test for reserved words. As the function is used at many places, I decided, to not touch it.