Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/nested: Nested tuple support #2582

Merged
merged 86 commits into from
Sep 16, 2020
Merged

Feature/nested: Nested tuple support #2582

merged 86 commits into from
Sep 16, 2020

Conversation

markheger
Copy link
Member

resolves #1679

markheger added 30 commits August 6, 2020 12:24
nested types, wip
c3cae9d
Merge pull request #5 from markheger/develop
574460e 
sync dev
nested types, work in progress
f6035c1
nested tuple types, work in progress
4538744
nested tuple types, from py to spl, work in progress
c896617
Merge pull request #6 from markheger/develop
d5985f5 
sync
ignore generated files
1e69991
check sink content for nested tuple types
4ae555d
check pyobject in dict
640c574
test suites added to standalone target
4f7f44b
multi level nested tuple
d5eba37
updated tests
336ee1f
adapt to new signature of convertAndAddToPythonDictionaryObject
c43aeab
add missing param
f6dbc21
resolve issues with some test cases
b319e8c
indention changed
0710383
test updated
ee4814e
test schema updated, another nested tuple level
ac40990
support multi nested tuple for dict to spl conversion
3e86faa
pylist get_item
7dcfeb5
test suite added
ebcc608
tests with py src a)dict b)tuple output
426f354
method convertNestedPythonTupleToSpl() added
2b110c0
(named tuple) pyspltuple2tuple conversion with nested tuple support
e8c72f1
tests updated, verify change of nested tuple in map
b3bc0d6
named tuple changes
4fce0e6
test updated for list of tuple
a5682d3
codegen for list of tuples
1855fe3
new perl function to retrieve generated SPL cpp type from header files
d547799
get generated SPL Cpp type for tuple in list
3211a6d
markheger and others added 18 commits September 14, 2020 17:09
nested tuples notes added
26c0a76
Merge pull request #2574 from markheger/feature/nested
d6f4274 
nested tuples notes added
test cases for list and map in deep nested tuple schemas
ff77cb7
code gen updated for nested types
4cc1a24
Merge pull request #2575 from RolefH/feature/nested
21bd113 
test cases for list and map in deep nested tuple schemas
Merge pull request #2576 from markheger/feature/nested
161d09d 
code gen updated for nested types
resolve test_py_source_tuple_list_nested_tuple_spl_sink
564de88
Merge pull request #2577 from markheger/feature/nested
f102b09 
resolve test_py_source_tuple_list_nested_tuple_spl_sink
test cases for list and map in deep nested tuple schemas, SPL->Py
47b8930
Merge pull request #2578 from RolefH/feature/nested
d5648f1 
test cases for list and map in deep nested tuple schemas, SPL->Py
resolve test_py_source_tuple_tuple_list_nested_tuple_spl_sink
6a576e6
resolve test_py_source_tuple_tuple_list_nested_tuple_spl_sink
8b153c0
Merge pull request #2579 from markheger/feature/nested
5b10329 
resolve test_py_source_tuple_tuple_list_nested_tuple_spl_sink
update codegen py2spl for map nested in nested tuple
bcd003a
Merge pull request #2580 from markheger/feature/nested
2b2cdd4 
update codegen py2spl for map nested in nested tuple
resolve nested map in nested tuple
9a597a4
1.16.0b
8dfafa0
Merge pull request #2581 from markheger/feature/nested
8b8fd13 
Feature/nested: 1.16.0b
@markheger markheger requested a review from a user September 15, 2020 16:34
@markheger markheger changed the title Feature/nested Feature/nested: Nested tuple support Sep 15, 2020
@markheger
Copy link
Member Author

ant clean all; cd test/python/; ant test.standalone

     [exec] ----------------------------------------------------------------------
     [exec] Ran 86 tests in 2930.718s
     [exec] OK (skipped=1)

BUILD SUCCESSFUL
Total time: 48 minutes 53 seconds

ghost
ghost reviewed Sep 16, 2020
View reviewed changes
com.ibm.streamsx.topology/opt/python/packages/streamsx/topology/schema.py Outdated
@@ -309,6 +309,15 @@ def _attribute_names(types):
def _attribute_pytypes(types):
pytypes = []
for attr in types:
#if isinstance(attr[0], tuple):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed

test/python/topology/test2_namedtuple.py
assert(False == res) # expected result: test failed
print ('-C- unsupported type check: PASSED')

def _test_spl_source_list_of_tuple_named_tuple_py_sink(self):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_test_spl_source_list_of_tuple_named_tuple_py_sink(self):

This test case is hidden, but should test a supported scenario.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

callable returns named tuple not dict, that is the difference
restrictions to named tuple objects needs to be mentioned

@markheger
Copy link
Member Author

some named tuple cases needs to reviewed in beta phase of the release

@markheger markheger merged commit 5aca467 into develop Sep 16, 2020
@markheger markheger deleted the feature/nested branch October 6, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
1.16 python_topology spl_python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested tuple: Support tuple as attribute type.
1 participant
@markheger