Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu_time always 0.0 #1124

Closed
LeonardSchmiester opened this issue Jun 10, 2020 · 5 comments
Closed

cpu_time always 0.0 #1124

LeonardSchmiester opened this issue Jun 10, 2020 · 5 comments
Assignees

Comments

@LeonardSchmiester
Copy link
Contributor

I simulated all benchmark models with the simulate_petab function (develop branch from today, but also happens for the current master branch) and the cpu_time in the returned rdatas is 0.0 for all models.

I tested it with forward / adjoint / no sensis and always got the same result for the cpu time.

petab_problem = petab.Problem.from_yaml(f'{benchmark_model}.yaml')

sys.path.insert(0, benchmark_model)
model_module = importlib.import_module(benchmark_model)
amici_model = model_module.getModel()

amici_solver = amici_model.getSolver()
amici_solver.setSensitivityOrder(1)

sim_results = simulate_petab(petab_problem=petab_problem,
                             amici_model=amici_model,
                             solver=amici_solver)

sim_results['rdatas'][0]['cpu_time']
Out[13]: 0.0
@LeonardSchmiester LeonardSchmiester added the new Newly created label Jun 10, 2020
@dweindl dweindl self-assigned this Jun 10, 2020
@dweindl dweindl added bug c++ and removed new Newly created labels Jun 10, 2020
@dweindl
Copy link
Member

dweindl commented Jun 10, 2020

Problem is that ReturnData::processSolver isn't called anywhere.

@dweindl
Copy link
Member

dweindl commented Jun 10, 2020

Also all of numSteps, numrhsevals, numnonlinsolvconvfails are probably empty / all zero.

@LeonardSchmiester
Copy link
Contributor Author

Also all of numSteps, numrhsevals, numnonlinsolvconvfails are probably empty / all zero.

Yes, can confirm that they are all zero.

dweindl added a commit that referenced this issue Jun 10, 2020
Fixes empty cpu_time, numSteps, numrhsevals, numnonlinsolvconvfails in ReturnData. Fixes #1124.
@dweindl
Copy link
Member

dweindl commented Jun 10, 2020

Proposed fix in 24d3497

@LeonardSchmiester
Copy link
Contributor Author

👍 that fixed the issue. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants