New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AggregatedObjective: objective-specific kwargs for call_unprocessed
#1068
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #1068 +/- ##
===========================================
- Coverage 88.16% 84.86% -3.31%
===========================================
Files 79 147 +68
Lines 5257 11399 +6142
===========================================
+ Hits 4635 9674 +5039
- Misses 622 1725 +1103
|
Looks reasonable but might be problematic to assume that keyword arguments between objectives are comparable. Instead, we could change I made this suggestion in a commit, feel free to revert if undesired. |
Objective-specific keyword arguments, where the dictionaries are | ||
ordered by the objectives. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to have it objective-specific 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
call_unprocessed
It should be possible to pass kwargs to AmiciObjective. At the moment, if you make an AggregatedObjective with a prior (which takes kwargs), and an AmiciObjective, trying to use the kwargs will lead to an error.