Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require and test python>=3.10 #1379

Merged
merged 12 commits into from
May 3, 2024
Merged

Require and test python>=3.10 #1379

merged 12 commits into from
May 3, 2024

Conversation

vwiela
Copy link
Contributor

@vwiela vwiela commented Apr 25, 2024

As seen in #1378 petab tests are failing due to use of syntax in AMICI that is not supported in python version <=3.9.

I guess, we should think about dropping the python support for python <=3.9.
Other packages as numpy already dropped support for 3.9 as well.
https://numpy.org/neps/nep-0029-deprecation_policy.html

Remove python 3.9
Remove python 3.9 and update to 3.11
Change python 3.9 by 3.11
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.48%. Comparing base (e197a8b) to head (e9abff6).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1379      +/-   ##
===========================================
+ Coverage    81.32%   84.48%   +3.15%     
===========================================
  Files          157      157              
  Lines        12933    12932       -1     
===========================================
+ Hits         10518    10925     +407     
+ Misses        2415     2007     -408     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Add python 3.10
Add python 3.12
Update from python 3.11 to 3.12
Update from python 3.11 to 3.12
Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but also added a commit so probably should not be last one to approve.

test/base/test_objective.py Outdated Show resolved Hide resolved
Copy link
Contributor

@m-philipps m-philipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

vwiela and others added 2 commits May 2, 2024 14:44
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@dweindl dweindl changed the title Update python support Require and test python>=3.10 May 3, 2024
@PaulJonasJost PaulJonasJost merged commit fc7b615 into develop May 3, 2024
17 of 18 checks passed
@PaulJonasJost PaulJonasJost deleted the update-python-support branch May 3, 2024 08:03
This was referenced May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants