-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require and test python>=3.10 #1379
Conversation
Remove python 3.9
Remove python 3.9 and update to 3.11
Change python 3.9 by 3.11
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1379 +/- ##
===========================================
+ Coverage 81.32% 84.48% +3.15%
===========================================
Files 157 157
Lines 12933 12932 -1
===========================================
+ Hits 10518 10925 +407
+ Misses 2415 2007 -408 ☔ View full report in Codecov by Sentry. |
Add python 3.10
Add python 3.12
Update from python 3.11 to 3.12
Update from python 3.11 to 3.12
5a5a76e
to
4c9377b
Compare
… the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but also added a commit so probably should not be last one to approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
As seen in #1378 petab tests are failing due to use of syntax in AMICI that is not supported in python version <=3.9.
I guess, we should think about dropping the python support for python <=3.9.
Other packages as numpy already dropped support for 3.9 as well.
https://numpy.org/neps/nep-0029-deprecation_policy.html