Update test_thermodynamic_integration
#1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1385 +/- ##
===========================================
- Coverage 84.51% 84.48% -0.03%
===========================================
Files 157 157
Lines 12956 12959 +3
===========================================
- Hits 10950 10949 -1
- Misses 2006 2010 +4 ☔ View full report in Codecov by Sentry. |
|
True, this is not neceassary as a test. It was included to check convergence of the evidence estimation. Okay for me to remove it to speed up testing time. |
arrjon
approved these changes
May 6, 2024
Doresic
approved these changes
May 6, 2024
dilpath
approved these changes
May 6, 2024
vwiela
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjusted
test_thermodynamic_integration, by lowering the number of chains by factor of 5 and only running 10 chains, as the comparison of more chains is not something that we should have to test imo.In local tests (Mac) it went from ~200sek to 20