-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Aggregated Objective Visualisations #1411
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1411 +/- ##
===========================================
- Coverage 83.89% 83.85% -0.05%
===========================================
Files 160 160
Lines 13067 13096 +29
===========================================
+ Hits 10963 10982 +19
- Misses 2104 2114 +10 ☔ View full report in Codecov by Sentry. |
For the moment I iterate over the objectives in However, I did not test the function using a petab problem with multiple amici models. Potentially, one needs to extract information from the petab measurement file specific to the corresponding model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks
Might be good to add a test in test/test_visualize.py
testing a case with an aggregated objective (similar to test_visualize_optimized_model_fit()
or an extension of it).
Fixes the isses mentioned in #1410 so
AggregatedObjective
can be used in thevisualize.model_fit
function.