Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to libpetab 0.4.0 #1422

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Update to libpetab 0.4.0 #1422

merged 2 commits into from
Jul 3, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jun 27, 2024

Adapt to and require petab>=0.4.0 Changing all petab.XXX to petab.v1.XXX. Most of petab.XXX is now deprecated.

@dweindl dweindl self-assigned this Jun 27, 2024
@dweindl dweindl force-pushed the test_petab branch 2 times, most recently from 94455d0 to 9595564 Compare July 1, 2024 14:37
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.72%. Comparing base (ba84aa6) to head (a6f5557).
Report is 1 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (ba84aa6) and HEAD (a6f5557). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (ba84aa6) HEAD (a6f5557)
12 2
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1422       +/-   ##
============================================
- Coverage    83.33%   68.72%   -14.62%     
============================================
  Files          161      161               
  Lines        13226    13226               
============================================
- Hits         11022     9089     -1933     
- Misses        2204     4137     +1933     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl changed the title [Test] check petab develop compatibility Update to libpetab 0.4.0 Jul 2, 2024
@dweindl dweindl marked this pull request as ready for review July 2, 2024 06:36
Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@dweindl dweindl merged commit 5a8e014 into ICB-DCM:develop Jul 3, 2024
18 checks passed
@dweindl dweindl deleted the test_petab branch July 3, 2024 08:12
@PaulJonasJost PaulJonasJost mentioned this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants