Disentangle amici and roadrunner #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ci imports into non dependencies
…ng base + roadrunner (should be with only base as well)
PaulJonasJost
requested review from
dweindl,
FFroehlich,
Doresic and
m-philipps
as code owners
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1429 +/- ##
========================================
Coverage 83.32% 83.33%
========================================
Files 161 161
Lines 13237 13243 +6
========================================
+ Hits 11030 11036 +6
Misses 2207 2207 ☔ View full report in Codecov by Sentry. |
dweindl
changed the title
dweindl
reviewed
Jul 15, 2024
FFroehlich
approved these changes
Jul 15, 2024
| @@ -1,3 +1,5 @@ | |||
| from __future__ import annotations | |||
There was a problem hiding this comment.
needed for the ParameterMapping (l168)
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
m-philipps
approved these changes
Jul 17, 2024
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing only pypesto[roadrunner], there are additional amici dependencies, mainly occurring in hierarchical (basically all of them typings, thus fixed through string type annotation)