disable progress bar in tests #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #799 +/- ##
=======================================
Coverage 90.27% 90.27%
=======================================
Files 106 106
Lines 7248 7249 +1
=======================================
+ Hits 6543 6544 +1
Misses 705 705
Continue to review full report at Codecov.
|
…fix_progress_bar_in_tests
jvanhoefer
approved these changes
Jan 19, 2022
| # loop over iterations | ||
| for i_sample in tqdm(range(int(n_samples))): # TODO test | ||
| for i_sample in tqdm(range(int(n_samples)), disable=not show_progress): | ||
| # TODO test |
There was a problem hiding this comment.
not sure, was there before. Would probably have to ask @yannikschaelte
There was a problem hiding this comment.
yeah I guess we wanted to add tests there, tbd independent of current pr
|
looks good! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #791