Added tests for better coverage

ICEAgency · Aug 7, 2018 · bd1b28c · bd1b28c
1 parent aba1c1d
commit bd1b28c
Show file tree

Hide file tree

Showing 7 changed files with 64 additions and 2 deletions.
diff --git a/composer.json b/composer.json
@@ -12,6 +12,7 @@
         }
     ],
     "require": {
+        "php": "^7.0",
         "rareloop/lumberjack-core": "^3.2.0"
     },
     "require-dev": {

diff --git a/src/AcfFields/CheckboxField.php b/src/AcfFields/CheckboxField.php
@@ -4,13 +4,15 @@
 
 use IceAgency\Lumberjack\AcfFields\Field;
 
+use Exception;
+
 class CheckboxField extends Field
 {
     public $type = 'checkbox';
 
     public $options = [];
 
-    public function withOptions($options)
+    public function withOptions($options = '')
     {
         if (!is_array($options)) {
             throw new Exception('You must provide an array of options with a CheckboxField');

diff --git a/src/AcfFields/RadioField.php b/src/AcfFields/RadioField.php
@@ -4,13 +4,15 @@
 
 use IceAgency\Lumberjack\AcfFields\Field;
 
+use Exception;
+
 class RadioField extends Field
 {
     public $type = 'radio';
 
     public $options = [];
 
-    public function withOptions($options)
+    public function withOptions($options = '')
     {
         if (!is_array($options)) {
             throw new Exception('You must provide an array of options with a RadioField');

diff --git a/tests/Unit/AcfFieldGroups/FieldGroupTest.php b/tests/Unit/AcfFieldGroups/FieldGroupTest.php
@@ -30,6 +30,15 @@ public function testCreateFieldGroup()
         ]);
     }
 
+    public function testCreateFieldGroupWithoutName()
+    {
+        $post_type_name = '';
+        $this->expectException(Exception::class);
+        $field_group = FieldGroup::create($post_type_name);
+
+        $this->assertNull($field_group);
+    }
+
     public function testAddField()
     {
         $post_type_name = 'post';

diff --git a/tests/Unit/AcfFields/CheckboxFieldTest.php b/tests/Unit/AcfFields/CheckboxFieldTest.php
@@ -4,6 +4,8 @@
 
 use PHPUnit\Framework\TestCase;
 
+use Exception;
+
 use IceAgency\Lumberjack\AcfFields\CheckboxField;
 
 class CheckboxFieldTest extends TestCase
@@ -24,6 +26,17 @@ public function testOptions()
         ]);
     }
 
+    public function testEmptyOptions()
+    {
+        $field_name = 'example_field';
+        $field = CheckboxField::create($field_name);
+
+        $this->expectException(Exception::class);
+        $field->withOptions();
+
+        $this->assertNull($field->options);
+    }
+
     public function testOptionalData()
     {
         $field_name = 'example_field';

diff --git a/tests/Unit/AcfFields/RadioFieldTest.php b/tests/Unit/AcfFields/RadioFieldTest.php
@@ -6,6 +6,8 @@
 
 use IceAgency\Lumberjack\AcfFields\RadioField;
 
+use Exception;
+
 class RadioFieldTest extends TestCase
 {
     public function testOptions()
@@ -24,6 +26,17 @@ public function testOptions()
         ]);
     }
 
+    public function testEmptyOptions()
+    {
+        $field_name = 'example_field';
+        $field = RadioField::create($field_name);
+
+        $this->expectException(Exception::class);
+        $field->withOptions();
+
+        $this->assertNull($field->options);
+    }
+
     public function testOptionalData()
     {
         $field_name = 'example_field';

diff --git a/tests/Unit/AcfFields/WysiwygFieldTest.php b/tests/Unit/AcfFields/WysiwygFieldTest.php
@@ -4,6 +4,8 @@
 
 use PHPUnit\Framework\TestCase;
 
+use Exception;
+
 use IceAgency\Lumberjack\AcfFields\WysiwygField;
 
 class WysiwygFieldTest extends TestCase
@@ -26,6 +28,16 @@ public function testTabs()
         $this->assertEquals($field->tabs, 'text');
     }
 
+    public function testInvalidTabs()
+    {
+        $field_name = 'example_field';
+        $field = WysiwygField::create($field_name);
+
+        $this->expectException(Exception::class);
+        $field->withTabs('other');
+        $this->assertNull($field->tabs);
+    }
+
     public function testToolbar()
     {
         $field_name = 'example_field';
@@ -40,6 +52,16 @@ public function testToolbar()
         $this->assertEquals($field->toolbar, 'basic');
     }
 
+    public function testInvalidToolbar()
+    {
+        $field_name = 'example_field';
+        $field = WysiwygField::create($field_name);
+
+        $this->expectException(Exception::class);
+        $field->withToolbar('other');
+        $this->assertNull($field->toolbar);
+    }
+
     public function testCanUploadMedia()
     {
         $field_name = 'example_field';