New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: extract async task lib #1390
Open
ClemDoum
wants to merge
14
commits into
master
Choose a base branch
from
feature/extract-task-lib
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClemDoum
force-pushed
the
feature/extract-task-lib
branch
from
April 24, 2024 13:19
e7a15de
to
aa77981
Compare
ClemDoum
force-pushed
the
feature/extract-task-lib
branch
4 times, most recently
from
April 29, 2024 08:19
133dd52
to
9894bb2
Compare
ClemDoum
force-pushed
the
feature/extract-task-lib
branch
2 times, most recently
from
May 13, 2024 10:31
d66f5ee
to
d04a921
Compare
ClemDoum
force-pushed
the
feature/extract-task-lib
branch
3 times, most recently
from
May 13, 2024 14:10
27920e4
to
a9e2e33
Compare
ClemDoum
force-pushed
the
feature/extract-task-lib
branch
from
May 13, 2024 14:12
a9e2e33
to
33a8f5d
Compare
Co-authored-by: Clément Doumouro <ClemDoum@users.noreply.github.com> Co-authored-by: Maxime Vanza Lutonda <mvanzalu@users.noreply.github.com>
Co-authored-by: Clément Doumouro <ClemDoum@users.noreply.github.com> Co-authored-by: Maxime Vanza Lutonda <mvanzalu@users.noreply.github.com>
Co-authored-by: Maxime Vanza Lutonda <mvanzalu@users.noreply.github.com>
Co-authored-by: Maxime Vanza Lutonda <mvanzalu@users.noreply.github.com>
Co-authored-by: Maxime Vanza Lutonda <mvanzalu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
datashare-app
)datashare-tasks
datashare-tasks
datashare-tasks
vs.datashare-async-tasks
)PR description
This PRs extracts the asynchronous tasks logic of DS in its own package. The goal of the operation is that the package can be used by other repos than DS if they want to implement async tasks (neo4j proeject for instance).
Changes
datashare-app
Removed
datashare-tasks
datashare-tasks
Added
datashare-tasks
repoChanged
CancellableCallable
byCancellableTask
CanceledEvent
intoCancelledEvent
Double progress
argument. TheString taskId
part of the progress is forwarded inside theTaskRunnerLoop
. This avoid the task implementer to possibly callprogress(taskId, progress)
with the wrongtaskId
.Left for later