Add a context-level query capability. #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devreal
requested changes
Jan 26, 2024
| { | ||
| parsec_device_module_t* dev; | ||
| va_list args; | ||
| va_start(args, cmd); |
There was a problem hiding this comment.
There are too many return points to place an va_end. Plus everything related to the va_list is on the stack, so returning should clean up everything.
bosilca
force-pushed
the
api/add_query_capability
branch
from
0c3320f
to
a7b8833
Compare
|
Added documentation for the vararg, and the different commands. |
devreal
approved these changes
Jan 26, 2024
abouteiller
requested changes
Jan 31, 2024
Augment the PaRSEC context API with query capabilities, allowing users to find the number of processes, cores and other information from a PaRSEC context. Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
bosilca
force-pushed
the
api/add_query_capability
branch
from
a7b8833
to
55ce910
Compare
abouteiller
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augment the PaRSEC context API with query capabilities, allowing users to find the number of processes, cores and other information from a PaRSEC context.