-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidated error handling when GPU only tests execute on CPU systems #644
Conversation
2d6e7dc
to
76da8f1
Compare
6069e74
to
f6a46b9
Compare
Ok so current approach is that the tests will not fail, just put out a warning in the output. This happens in CI, but also happens when running ctest manually (e.g., running with @therault has been working with Geri to integrate the workflow tags into the ctest logic, but that is currently stalled so lets move with this for now. |
Why not returning a specific error code from the tests to indicate that the test requires hardware not available. We could then use expect to identify tests that cannot be run because the CI does not have the specific hardware (aka. the tag). |
|
Fixes issue #641
parsec_fatal
so maybe that is already clear enough?