Suggestions from github ai

ICRAR · May 23, 2024 · d83685f · d83685f
1 parent db31d40
commit d83685f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/Edge.ts b/src/Edge.ts
@@ -443,11 +443,10 @@ export class Edge {
 
         // check if the edge already exists in the graph, there is no point in a duplicate
         for (const edge of eagle.logicalGraph().getEdges()){
-            if (edge.getSrcNodeKey() === sourceNodeKey &&
-                edge.getSrcPortId() === sourcePortId &&
-                edge.getDestNodeKey() === destinationNodeKey &&
-                edge.getDestPortId() === destinationPortId &&
-                edge.getId() !== edgeId){
+            const isSrcMatch = edge.getSrcNodeKey() === sourceNodeKey && edge.getSrcPortId() === sourcePortId;
+            const isDestMatch = edge.getDestNodeKey() === destinationNodeKey && edge.getDestPortId() === destinationPortId;
+
+            if ( isSrcMatch && isDestMatch && edge.getId() !== edgeId){
                 const x = Errors.ShowFix("Edge is a duplicate. Another edge with the same source port and destination port already exists", function(){Utils.showEdge(eagle, edgeId);}, function(){Utils.fixDeleteEdge(eagle, edgeId);}, "Delete edge");
                 Edge.isValidLog(edgeId, Eagle.LinkValid.Invalid, x, showNotification, showConsole, errorsWarnings);
             }

diff --git a/src/Utils.ts b/src/Utils.ts
@@ -1989,7 +1989,7 @@ export class Utils {
         object.setId(Utils.uuidv4());
     }
 
-    static newFieldId(eagle: Eagle, node: Node, field: Field){
+    static newFieldId(eagle: Eagle, node: Node, field: Field): void {
         const oldId = field.getId();
         const newId: string = Utils.uuidv4();