Eagle 1222 #683
Merged
Eagle 1222 #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error on eagle load
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @M-Wicenec - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Comment on lines
+79
to
+80
| .navbar .dropdown-item{ | ||
| padding: .05rem 1rem; |
There was a problem hiding this comment.
suggestion: Padding value might be too small.
The padding value of .05rem might be too small and could lead to rendering issues on some devices. Consider increasing it slightly.
Suggested change
| .navbar .dropdown-item{ | |
| padding: .05rem 1rem; | |
| .navbar .dropdown-item{ | |
| padding: .25rem 1rem; | |
| } |
| @@ -1801,7 +1801,7 @@ export class GraphRenderer { | |||
|
|
|||
| static SCREEN_TO_GRAPH_POSITION_X(x:number) : number { | |||
| const eagle = Eagle.getInstance(); | |||
| if(x===null){ | |||
| if(x===null && GraphRenderer.dragCurrentPosition){ | |||
There was a problem hiding this comment.
issue (bug_risk): Potential issue with null check.
The condition x===null && GraphRenderer.dragCurrentPosition might not cover all edge cases. Consider checking if GraphRenderer.dragCurrentPosition is defined before accessing its properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.