can now use shit plus ctrl to drag to deselect multiple nodes from se… #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @M-Wicenec - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -1090,6 +1090,7 @@ export class GraphRenderer { | |||
|
|
|||
| static mouseMove(eagle: Eagle, event: JQuery.TriggeredEvent) : void { | |||
| const e: MouseEvent = event.originalEvent as MouseEvent; | |||
| GraphRenderer.ctrlDrag = event.ctrlKey; | |||
There was a problem hiding this comment.
suggestion: Consider renaming 'ctrlDrag' for clarity.
The variable name 'ctrlDrag' might be misleading as it suggests dragging with the control key. Consider renaming it to something more descriptive like 'isCtrlPressed' to better reflect its purpose.
Suggested change
| GraphRenderer.ctrlDrag = event.ctrlKey; | |
| GraphRenderer.isCtrlPressed = event.ctrlKey; |
| } | ||
| } | ||
|
|
||
| objects.forEach(function(element){ | ||
| eagle.editSelection(Eagle.RightWindowMode.Hierarchy, element, Eagle.FileType.Graph ) | ||
| }) | ||
| } | ||
| GraphRenderer.ctrlDrag = false; |
There was a problem hiding this comment.
suggestion: Reset 'ctrlDrag' earlier in the method.
Consider resetting 'ctrlDrag' earlier in the method to ensure it is always reset, even if an exception occurs later in the method.
Suggested change
| GraphRenderer.ctrlDrag = false; | |
| GraphRenderer.ctrlDrag = false; | |
| try { | |
| eagle.editSelection(Eagle.RightWindowMode.Hierarchy, element, Eagle.FileType.Graph) | |
| } catch (error) { | |
| // Handle error if necessary | |
| } | |
| GraphRenderer.selectionRegionStart.x = 0; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…leciton