Skip to content

Commit

Permalink
Skip NGAS tests
Browse files Browse the repository at this point in the history
As we can't rely on an external service for unit tests. Update the NGAS
host to one that will be maintained for manual tests when required.
  • Loading branch information
juliancarrivick committed Jan 11, 2024
1 parent a0d746e commit 2094405
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions daliuge-engine/test/apps/test_docker.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,15 +160,15 @@ def assertMsgIsCorrect(msg, command):
msg = 'This is a message with a double quotes: "'
assertMsgIsCorrect(msg, "echo -n '{0}' > %o0".format(msg))

# @unittest.skip
@unittest.skip
def test_dataURLReference(self):
"""
A test to check that DROPs other than FileDROPs and DirectoryContainers
can pass their dataURLs into docker containers
"""
self._ngas_and_fs_io("echo -n '%iDataURL0' > %o0")

# @unittest.skip
@unittest.skip
def test_refer_to_io_by_uid(self):
"""
A test to check that input and output Drops can be referred to by their
Expand All @@ -181,7 +181,7 @@ def _ngas_and_fs_io(self, command):
a = NgasDROP(
"HelloWorld_out.txt", "HelloWorld_out.txt"
) # not a filesystem-related DROP, we can reference its URL in the command-line
a.ngasSrv = "ngas.ddns.net"
a.ngasSrv = "ngas.icrar.org"
b = DockerApp("b", "b", image="ubuntu:14.04", command=command)
c = FileDROP("c", "c")
b.addInput(a)
Expand Down
6 changes: 3 additions & 3 deletions daliuge-engine/test/apps/test_simple.py
Original file line number Diff line number Diff line change
Expand Up @@ -175,14 +175,14 @@ def test_parallelHelloWorld(self):
droputils.allDropContents(f[i]),
)

# @unittest.skip
@unittest.skip
def test_ngasio(self):
nd_in = NgasDROP("HelloWorld_out.txt", "HelloWorld_out.txt")
nd_in.ngasSrv = "ngas.ddns.net"
nd_in.ngasSrv = "ngas.icrar.org"
b = CopyApp("b", "b")
did = "HelloWorld-%f" % time.time()
nd_out = NgasDROP(did, did, len=11)
nd_out.ngasSrv = "ngas.ddns.net"
nd_out.ngasSrv = "ngas.icrar.org"
nd_out.len = nd_in.size
d = CopyApp("d", "d")
i = InMemoryDROP("i", "i")
Expand Down
4 changes: 2 additions & 2 deletions daliuge-translator/test/dropmake/logical_graphs/nagsIo.graph
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
"readonly": false,
"text": "NGAS Server",
"type": "Unknown",
"value": "ngas.ddns.net"
"value": "ngas.icrar.org"
},
{
"defaultValue": "",
Expand Down Expand Up @@ -204,7 +204,7 @@
"readonly": false,
"text": "NGAS Server",
"type": "Unknown",
"value": "ngas.ddns.net"
"value": "ngas.icrar.org"
},
{
"defaultValue": "",
Expand Down

0 comments on commit 2094405

Please sign in to comment.