Skip to content

Commit

Permalink
Skip multiprocessing tests by default
Browse files Browse the repository at this point in the history
These tests are not stable (see YAN-976 for some examples), but their
instability has been hidden by the fact that they are never run on
Travis anyway. On my laptop though they often cause issues, making the
whole test suite unreliable.

This commit changes the skip condition for the multiprocessing tests to
only run if a specific environment variable is set (it isn't by
default). This will allow us to continue hiding the problem, but in a
more controller manner, while also giving us an easy switch to turn the
tests on when we start addressing their problems.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
  • Loading branch information
rtobar committed Jun 14, 2022
1 parent 83dbda2 commit a86dcac
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion daliuge-engine/test/manager/test_dm.py
Original file line number Diff line number Diff line change
Expand Up @@ -648,6 +648,7 @@ def test_run_invalid_shmem_graph(self):



@unittest.skipIf(multiprocessing.cpu_count() < 4, "Not enough threads to test multiprocessing")
@unittest.skipUnless(os.environ.get('DALIUGE_RUN_MP_TESTS', '0') == '1',
"Unstable multiprocessing tests not run by default")
class TestDMParallel(NodeManagerTestsBase, unittest.TestCase):
nm_threads = multiprocessing.cpu_count()

0 comments on commit a86dcac

Please sign in to comment.