Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yan 852 #105

Merged
merged 8 commits into from
Feb 7, 2022
Merged

Yan 852 #105

merged 8 commits into from
Feb 7, 2022

Conversation

awicenec
Copy link
Contributor

@awicenec awicenec commented Feb 5, 2022

Added support for applicationParams and fixed a few things in addition along the way:

  1. applicationParams are now parsed and appended to both bash, MPI and docker command lines
  2. Default prefix for parameters is '--' for parameters with a single letter name this is changed to '-' instead.
  3. Input and output redirects have been added to the engine code to the start and end of the final command line
  4. The original command line parameters and the really old Arg%0d arguments are still working
  5. daliuge-engine inside a container is now started with the same user starting the container, rather than root. Fixes the annoying issue that files generated during run-time by the engine are owned by root and can't be removed without root permission.
  6. Removed a heap of code from pg_generator on the way as well. This part of the code can be further improved and stream-lined. The issue is that pg_generator is performing a lot of logic on parameters of drops, but all of that should be done in the engine only.

@coveralls
Copy link

Coverage Status

Coverage decreased (-12.8%) to 66.739% when pulling bda8081 on yan-852 into f92b8ba on master.

@coveralls
Copy link

coveralls commented Feb 5, 2022

Coverage Status

Coverage decreased (-0.06%) to 79.503% when pulling a91cdbc on yan-852 into f92b8ba on master.

Copy link
Collaborator

@james-strauss-uwa james-strauss-uwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending removal of shared objects from strip-docker-image-1164389/

@awicenec awicenec merged commit 2ef8b34 into master Feb 7, 2022
@awicenec awicenec deleted the yan-852 branch February 7, 2022 05:13
awicenec added a commit that referenced this pull request May 19, 2022
pritchardn pushed a commit that referenced this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants