Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyzmq version lock #155

Merged
merged 1 commit into from
May 19, 2022
Merged

pyzmq version lock #155

merged 1 commit into from
May 19, 2022

Conversation

calgray
Copy link
Collaborator

@calgray calgray commented May 19, 2022

pyzmq which is a dependency of zerorpc just released version 23.0.0 but contains breaking changes when running dlg daemon -vv with the following exception:

Traceback (most recent call last):
  File "/dlg/bin/dlg", line 8, in <module>
    sys.exit(run())
  File "/dlg/lib/python3.8/site-packages/dlg/common/tool.py", line 166, in run
    commands[cmd][1](sys.argv[1:])
  File "/dlg/lib/python3.8/site-packages/dlg/common/tool.py", line 106, in wrapped
    f(parser, *args, **kwargs)
  File "/dlg/lib/python3.8/site-packages/dlg/common/tool.py", line 100, in __call__
    return getattr(module, fname)(*args, **kwargs)
  File "/dlg/lib/python3.8/site-packages/dlg/manager/proc_daemon.py", line 392, in run_with_cmdline
    daemon = DlgDaemon(opts.master, opts.noNM, opts.noZC, opts.verbose - opts.quiet)
  File "/dlg/lib/python3.8/site-packages/dlg/manager/proc_daemon.py", line 107, in __init__
    self.startNM()
  File "/dlg/lib/python3.8/site-packages/dlg/manager/proc_daemon.py", line 179, in startNM
    logger.info("Starting Node Drop Manager with args: %s" % (" ".join(args)))
  File "/usr/lib/python3.8/logging/__init__.py", line 1446, in info
    self._log(INFO, msg, args, **kwargs)
  File "/usr/lib/python3.8/logging/__init__.py", line 1587, in _log
    record = self.makeRecord(self.name, level, fn, lno, msg, args,
  File "/dlg/lib/python3.8/site-packages/dlg/runtime/__init__.py", line 51, in makeRecord
    from ..manager import session
  File "/dlg/lib/python3.8/site-packages/dlg/manager/session.py", line 41, in <module>
    from .. import rpc
  File "/dlg/lib/python3.8/site-packages/dlg/rpc.py", line 35, in <module>
    import zerorpc
  File "/dlg/lib/python3.8/site-packages/zerorpc/__init__.py", line 33, in <module>
    from .core import *
  File "/dlg/lib/python3.8/site-packages/zerorpc/core.py", line 314, in <module>
    class Pusher(SocketBase):
  File "/dlg/lib/python3.8/site-packages/zerorpc/core.py", line 316, in Pusher
    def __init__(self, context=None, zmq_socket=zmq.PUSH):
AttributeError: module 'zerorpc.gevent_zmq' has no attribute 'PUSH'

Ideally zerorpc needs a minor update to depend on pyzmq~=22.3.0 but until then we can specify it for daliuge

@coveralls
Copy link

coveralls commented May 19, 2022

Coverage Status

Coverage remained the same at 81.001% when pulling f875158 on pyzmq-lock into 833f61b on master.

@calgray calgray merged commit 69cfc44 into master May 19, 2022
awicenec pushed a commit that referenced this pull request May 19, 2022
pritchardn pushed a commit that referenced this pull request May 20, 2022
@awicenec awicenec deleted the pyzmq-lock branch May 9, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants