Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liu 186 - Register DIM with zeroconf with MM #156

Merged
merged 15 commits into from
Jun 1, 2022
Merged

Liu 186 - Register DIM with zeroconf with MM #156

merged 15 commits into from
Jun 1, 2022

Conversation

pritchardn
Copy link
Collaborator

  • Adds REST APIs for MM to add/remove DIMs & Nodes from DIMs
  • Adds zeroconf discovery of DIMs
  • Adds nm_dim_assigner - assigns NMs to DIMs as they come on/off-line
  • Adds associated tests asserting this functionality works when zeroconf is enabled, and does not work when disabled.

Limitations:

  • Does not handle multiple DIMs
  • Performs no assignments with more than a single DIM

Adds REST APIs for MM to add/remove DIMs & Nodes from DIMs
Adds zeroconf discovery of DIMs
Adds nm_dim_assigner - assigns NMs to DIMs as they come on/off-line
Adds associated tests asserting this functionality works when zeroconf is enable, and does not work when disabled.
@coveralls
Copy link

Coverage Status

Coverage decreased (-17.0%) to 64.002% when pulling 6d3d6fb on liu-186-2 into 06cd2c3 on master.

@coveralls
Copy link

coveralls commented May 20, 2022

Coverage Status

Coverage increased (+0.1%) to 81.142% when pulling 3e993f3 on liu-186-2 into 06cd2c3 on master.

Copy link
Contributor

@rtobar rtobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on reviewing this, I finally got the change to give it a close look.

Overall the code looks good to me, nice to see tests going alongside the new code (and coverage going up 😄). Most changes are minor things, so hopefully it won't be too much of a burden to act on them.

daliuge-common/dlg/clients.py Outdated Show resolved Hide resolved
daliuge-common/dlg/clients.py Outdated Show resolved Hide resolved
daliuge-common/dlg/clients.py Outdated Show resolved Hide resolved
daliuge-common/dlg/clients.py Outdated Show resolved Hide resolved
daliuge-engine/dlg/manager/proc_daemon.py Outdated Show resolved Hide resolved
daliuge-engine/dlg/nm_dim_assigner.py Outdated Show resolved Hide resolved
daliuge-engine/dlg/manager/proc_daemon.py Outdated Show resolved Hide resolved
daliuge-engine/dlg/manager/proc_daemon.py Show resolved Hide resolved
daliuge-engine/dlg/manager/proc_daemon.py Outdated Show resolved Hide resolved
daliuge-engine/test/manager/test_daemon.py Outdated Show resolved Hide resolved
@pritchardn
Copy link
Collaborator Author

Thank you for the feedback/suggestions by the way, it's very appreciated :D

Copy link
Contributor

@rtobar rtobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a final small detail and I'm happy to get this merged.

I found wait_until and friends a bit confusing and verbose, but (if you agree) I'll compress that a bit afterwards to not block this PR any longer.

daliuge-engine/dlg/manager/proc_daemon.py Outdated Show resolved Hide resolved
@rtobar
Copy link
Contributor

rtobar commented May 31, 2022

Changes look good to me, let's ignore the failure for the time being, I've addressed it in 05076f9

@pritchardn pritchardn merged commit 82fa3e8 into master Jun 1, 2022
@pritchardn pritchardn deleted the liu-186-2 branch June 1, 2022 03:13
@rtobar rtobar mentioned this pull request Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants