Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAN-969 docs and tests #164

Merged
merged 6 commits into from
May 27, 2022
Merged

YAN-969 docs and tests #164

merged 6 commits into from
May 27, 2022

Conversation

calgray
Copy link
Collaborator

@calgray calgray commented May 25, 2022

Added documentation and tests for several changes made to python components and pyfunc components in YAN-969. After changes in #159 it's also no longer required to cast enum params in the run method.

@coveralls
Copy link

coveralls commented May 25, 2022

Coverage Status

Coverage increased (+0.1%) to 81.025% when pulling f904cdf on YAN-969-docs into a47cb17 on master.

@calgray calgray changed the title Draft: YAN-969 docs and tests YAN-969 docs and tests May 27, 2022
@calgray calgray self-assigned this May 27, 2022
daliuge-engine/dlg/apps/pyfunc.py Outdated Show resolved Hide resolved
Pyfunc Components
=================

Pyfunc components are generalized python component that can be configured to behave as a custom python component entirely through component parameters and application arguments. A pyfunc component
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add 's' to end of "generalized python component"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll extend this further in collaboration with Andreas as some parameters like func_code need further attention

@calgray calgray merged commit eb03f56 into master May 27, 2022
@awicenec awicenec deleted the YAN-969-docs branch May 9, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants