Lessen resource usage when multiprocessing not in use #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the problems with the current multiprocessing support in daliuge is that it requires too many resources. This is because each DropProxy object is creating its own RPCClient, which internally create their own ZMQ context. This not only increases the runtime requirements of the system (more objects need to be created, etc.) but also puts pressure on system resources. This situation is described in detail in YAN-976, and the test/manager/test_dm.py::TestDM::test_many_relationships unit test in particular triggers this issue with ease. This commit implements a partial fix for this issue. While it doesn't take care of the problem itself, it identifies when a DropProxy is created from a NodeManager that is *not* using multiprocessing support, and avoid creating an RPCClient instance itself, instead using the client provided as a parameter. This brings stability back to the daliuge runtime when multiprocessing isn't used, containing the resource over-usage to only when strictly necessary. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
pritchardn
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the problems with the current multiprocessing support in daliuge
is that it requires too many resources. This is because each DropProxy
object is creating its own RPCClient, which internally create their own
ZMQ context. This not only increases the runtime requirements of the
system (more objects need to be created, etc.) but also puts pressure on
system resources. This situation is described in detail in YAN-976, and the
test/manager/test_dm.py::TestDM::test_many_relationships unit test in
particular triggers this issue with ease.
This commit implements a partial fix for this issue. While it doesn't
take care of the problem itself, it identifies when a DropProxy is
created from a NodeManager that is not using multiprocessing support,
and avoid creating an RPCClient instance itself, instead using the
client provided as a parameter. This brings stability back to the
daliuge runtime when multiprocessing isn't used, containing the resource
over-usage to only when strictly necessary.
Signed-off-by: Rodrigo Tobar rtobar@icrar.org