Liu 281 - Browser driven graph deployment to standard engines #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awicenec
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the OOD implementation, this PR allows the browser to submit graphs to a standard DALiuGE engine instance. This is termed a REST-direct deployment (as opposed to a REST-OOD or Direct deployment).
There is associated documentation that describes graph deployment for all currently supported scenarios.
This also adds to the deployment options in the translator browser UI, from REST to REST-direct and REST-OOD. Eventually, creating a single REST option with additional logic to find the right deployment method would be ideal.
CORS is of course a little tricky to navigate with this one, Chrome browsers complain but run, firefox is fussier.
Setting the translator and engine URLs to 'localhost' (when testing locally of course) seems to do the trick.