Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liu 303 - Correcting Scheduler Algorithms #202

Merged
merged 10 commits into from
Sep 20, 2022
Merged

Liu 303 - Correcting Scheduler Algorithms #202

merged 10 commits into from
Sep 20, 2022

Conversation

pritchardn
Copy link
Collaborator

The PR mostly corrects the behaviours of several translation algorithms.
By adding tests for each translation algorithm specifically, their validity is confirmed (although there are still some ways to go for correctness testing). The PSO option in particular used outdated networkX calls and handled DOP incorrectly.
In future, re-implementing the entire translator should be considered.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 82.646% when pulling 484ec0a on LIU-303 into 30bc92a on master.

@pritchardn pritchardn marked this pull request as ready for review September 20, 2022 04:19
Copy link
Contributor

@awicenec awicenec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup of imports, thanks.

@pritchardn pritchardn merged commit 28cd9d8 into master Sep 20, 2022
@pritchardn pritchardn deleted the LIU-303 branch September 20, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants