Liu 303 - Correcting Scheduler Algorithms #202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR mostly corrects the behaviours of several translation algorithms.
By adding tests for each translation algorithm specifically, their validity is confirmed (although there are still some ways to go for correctness testing). The PSO option in particular used outdated networkX calls and handled DOP incorrectly.
In future, re-implementing the entire translator should be considered.