-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YAN-424 - CWL output to stdout #22
Conversation
…zip_file, can be written to file or to stdout externally.
…le. File is completely built in memory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! My only suggestion is around passing the final file object as a parameter to create_workflow
instead of accumulating in memory first; that way the writing is done directly to the final "target".
…te_workflow(). Use six.b instead on common.s2b. Remove extra uses of io.BytesIO that were not required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks even better now, thanks for the great work :)
Make the "dlg cwl" command output a zip file to stdout when no output file is specified by the user.
The main change is in tool_commands.py, where the cwl command now uses _open_o() with opts.output to send output to stdout.
Other changes are: